mov-cli / mov-cli

Watch everything from your terminal.
https://mov-cli.github.io/
MIT License
721 stars 47 forks source link

[BUG] "mov-cli --edit" outputs "sh: 1: nano: not found" #272

Closed IceAsteroid closed 7 months ago

IceAsteroid commented 7 months ago

Describe the bug: I've set up the env variable export EDITOR=nvim

In order, if in any case, that lower case for it would work, I also set up export editor=nvim, but still no luck.

Expected behavior: Being able to switch to another editor like vim.

Error: Good Morning, user. It's 10:20 AM on a beautiful Thursday!

[DEBUG] (mov_cli) - Config -> {'version': 1, 'player': 'mpv', 'debug': True, 'ui': {'fzf': True}, 'plugins': {'test': 'mov-cli-test'}} sh: 1: nano: not found

Python 3.12.2 (main, Feb 15 2024, 06:47:30) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

Platform (please complete the following information):

Additional context / possible cause or solution: Add any other context about the problem here or possible causes and solutions.

Version 4.2.5

r3tr0ananas commented 7 months ago

You need to set the editor inside the config, but you can't edit it because nano is the standard editor and you don't have it.

r3tr0ananas commented 7 months ago

You can also edit the config file, see the Wiki

THEGOLDENPRO commented 7 months ago

Yeah didn't add support for the EDITOR environment variable yet. I will add it soon. 👍

THEGOLDENPRO commented 7 months ago

For now you can do:

{your-editor} ~/.config/mov-cli/config.toml
IceAsteroid commented 7 months ago

Ok, copy that :)

Setting up editor = "nvim" in the config.toml works

r3tr0ananas commented 7 months ago

Is now added with this commit: https://github.com/mov-cli/mov-cli/commit/3cd9b9c556f0fc4cef32fa9bd859d42e1a4f588b