search

movableink / doorman

HTTP Proxy + OAuth
MIT License
167 stars 52 forks source link

Error configuring github access proxy in doorman. #11

Closed romankor closed 10 years ago

romankor commented 10 years ago

Hi Guy I know that might not be your fault but you might know the answer. Here is the issue i have opened to everyauth.

https://github.com/bnoguchi/everyauth/issues/471

Thanks Roman

Afterglow commented 10 years ago

Had the same problem with google apps auth. Appears to be related to the way everyauth is being used. I added this code which appeared to make it function but i'm not sure inserting this as a blank method is necessarily a 'fix' so I won't create a PR. I don't know what doorman is using the method for.

everyauth.everymodule.findUserById( function (userId, callback) {
});
mnutt commented 10 years ago

The proxy is higher precedence than everyauth, and should only let through requests that have no session, so ideally that code path should never be hit. My guess is that I somehow missed a case where the user successfully oauth'd, but that the auth isn't acceptable. (for instance, you locked it down to a specific company, and the user authed with a user not in that company) I put a few more checks in place; could you check out master and see if that fixes the problem?

romankor commented 10 years ago

Everything works now !! Thanks a lot