movableink / doorman

HTTP Proxy + OAuth
MIT License
167 stars 52 forks source link

Cannot start doorman #19

Open coryking opened 9 years ago

coryking commented 9 years ago

Hello,

Ever since yesterday's commits, I cannot start doorman. I get the error below. When I revert to 3efbe2d everything works.

/srv/doorman/lib/modules/google.js:5
var requiredDomain = conf.modules.google.requiredDomain;
                                        ^
TypeError: Cannot read property 'requiredDomain' of undefined
    at Object.<anonymous> (/srv/doorman/lib/modules/google.js:5:41)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/srv/doorman/app.js:16:14)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)

This is my config file:

module.exports = {
  // port to listen on.  Can't be < 1024 cause this never runs as root
  port: 8080,
  hostname: 'https://a.domain.com',

  proxyTo: {
    host: 'localhost',
    port: 5601
  },

  sessionSecret: 'secret',
  sessionCookieMaxAge: false,

  modules: {
    // Register a new oauth app on Github at
    // https://github.com/account/applications/new
    github: {
      appId: 'stuff',
      appSecret: 'stuff',
      entryPath: '/oauth/github',
      callbackPath: '/oauth/github/callback',
      requiredOrganization: 'stuff' // short organization name
    }

    // Register a new oauth app on Google Apps at
    // https://code.google.com/apis/console
    //google: {
    //  appId: 'YOUR-GOOGLE-CLIENT-ID',
    //  appSecret: 'YOUR-GOOGLE-CLIENT-SECRET',
    //  requiredDomain: 'yourdomain.com'
    //}
  }
};
mnutt commented 9 years ago

Sorry about that! Try pulling master and it should work. The code was making some faulty assumptions that you have all modules loaded.