Modified google login to enable both domain and email at the same time

movableink / doorman

HTTP Proxy + OAuth

MIT License

167 stars 52 forks source link

Modified google login to enable both domain and email at the same time #29

Closed the-smooth-operator closed 9 years ago

the-smooth-operator commented 9 years ago

I did this modification for my personal benefit, but as I want to keep using the master branch of doorman without patch all the time, I am doing this pull request which could be useful for some people.

mnutt commented 9 years ago

Thanks for the pull request. Given that this is an edge case with an unspecified behavior (whether we require matching domain OR email, or domain AND email) I'm hesitant to add it right now because the consequences of people assuming AND and having it be OR are much worse.

mnutt commented 9 years ago

I'm going to close this for now but at some point I want to shore up the organization/email configuration and I'll try to figure out if there's a good way to support this use case.