movableink / webkit

Unofficial mirror of the WebKit SVN repository
http://www.webkit.org/
59 stars 11 forks source link

Restore qwebelement rtti #11

Closed mnutt closed 1 year ago

mnutt commented 1 year ago

In https://github.com/movableink/webkit/commit/2caecbbaa24411f57522796737600cd5bee6cfec we disabled rtti for QWebElement in order to get the build working, but this broke API compatibility for users.

The issue is that QtWebKit exposes runtime type information in its API, but WebKit/WebCore has rtti disabled (via -fno-rtti). With QWebElement calling into WebCore/JSC via evaluateJavaScript, we get linking errors due to missing typeinfo for JSC::SourceProvider.

This PR splits out the code that creates the JSC::SourceProvider into a separate source file (EvaluateJS.cpp) which does not have rtti disabled.