Merge upstream 2024-06-30 (qt6)

movableink / webkit

Unofficial mirror of the WebKit SVN repository

http://www.webkit.org/

59 stars 11 forks source link

Merge upstream 2024-06-30 (qt6) #41

Open mnutt opened 1 month ago

mnutt commented 1 month ago

Upstream changes up to 2024-06-30.

Notable:

More usage of std::span. Some of this has broken automatic conversion between qt and webkit string types, and there is likely some cleanup work needed to ensure this is safe/performant
Sync upstream changes to texmap to our vendored version
This PR supersedes https://github.com/movableink/webkit/pull/40 so everything in that one as well.

chaplin89 commented 1 month ago

Hi @mnutt , is this still a work in progress? Seems like something is not compiling, at least for me. In particular I can't get the gstreamer/audio part to compile. Are you excluding those during the compilation or can you explain how are you compiling it?

Thanks!

mnutt commented 3 weeks ago

@chaplin89 sorry about that, I had hoped to get it done before I went on vacation but didn't quite get there.

You're totally right about GStreamer. It has unfortunately been broken for a while but was default-disabled in previous releases but now isn't. I looked at it for a few days and have a separate branch with it compiling with USE_GSTREAMER=ON, but videos aren't actually displaying yet. So I may disable in the build for now and continue working on that.

chaplin89 commented 3 weeks ago

@mnutt thanks for the answer, no worries!

I'm not much interested in gstreamer, I was wondering about that only because it was breaking the compilation and I was wondering if I was missing something.

Sorry I have another question, do you have any instructions to build this on windows? I'm interested in the project and I can potentially help with something. I was wondering how to build it on windows without much trial and error (if you are still supporting windows in your fork). Thank you!