search

move-coop / parsons

A python library of connectors for the progressive community.
Other
254 stars 125 forks source link

Remove obsolete argument to google storage client list_blobs() #1038

Closed austinweisgrau closed 2 months ago

austinweisgrau commented 2 months ago

match_glob is not a valid argument to google.storage.Client().list_blobs()

I can't really tell when this argument was deprecated, it doesn't exist even in the pinned version of the google-cloud-storage package. Not sure how this broke.

austinweisgrau commented 2 months ago

IDK if I'm right here - the argument is in the documentation https://cloud.google.com/python/docs/reference/storage/latest/google.cloud.storage.client.Client#google_cloud_storage_client_Client_list_blobs

But if I run

from google.cloud import storage

storage.Client().list_blobs('some_bucket', match_glob='something')

then I'm getting

TypeError: Client.list_blobs() got an unexpected keyword argument 'match_glob'

Might be some kind of packaging error on the google-cloud-storage project

Trying this with google-cloud-storage versions 2.8.0 and 2.10.0 which is pinned by parsons. Getting the same results

austinweisgrau commented 2 months ago

Made an upstream issue https://github.com/googleapis/python-storage/issues/1266

austinweisgrau commented 2 months ago

Nevermind, I got my versions confused somehow. This argument works with the pinned version of google-cloud-storage>=2.10.0