search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
262 stars 132 forks source link

Redshift get_table_definition method based on non-standard Redshift views #301

Open eliotst opened 4 years ago

eliotst commented 4 years ago

The get_table_definition + get_table_definitions methods in Redshift are based on views that aren't standard in Redshift, so these functions will not work for most people. We should either rework the SQL in the methods to use only standard Redshift functionality, or else remove them.

dannyboy15 commented 4 years ago

I ran into this issue as well. I fixed it locally by including the sql that generates the views directly in parsons. I'll open a PR to push my changes.

ChrisC commented 3 years ago

Just noting that we merged in these changes but had to walk them back in #589 because we were seeing errors in some of our pipelines that use these methods.