Closed elyse-weiss closed 1 year ago
Looks like there's an issue with linting. You can now run a single black command to fix linting issues. Unfortunately the docs are not up-to-date with our process because we haven't cut a release lately, but you can see the commands in the most recent docs:
flake8 --max-line-length=100 --extend-ignore=E203,W503 parsons black parsons
@Jason94 let me know how I can point this toward the major release
@Jason94 can you confirm I didn't mess anything up when I merged conflicts?
Let's get this landed. I think per our discussion on Slack, this doesn't actually need to target the major release. @elyse-weiss, can you confirm that the method you're altering, drop_dependencies_for_cols
, is not exposed in the documentation, and that the methods that do call it say that the drop cascades, even though it currently doesn't?
Yes, this change is in line with current documentation.
Okay, great! Can you update this to point back to main instead of major release, then? Sorry for the back-and-forth and accompanying delay.
done! should I go ahead and merge?
Yup, we're good to go!
Closes #818