search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
261 stars 132 forks source link

Drop dependencies for cols needs a CASCADE #819

Closed elyse-weiss closed 1 year ago

elyse-weiss commented 1 year ago

Closes #818

shaunagm commented 1 year ago

Looks like there's an issue with linting. You can now run a single black command to fix linting issues. Unfortunately the docs are not up-to-date with our process because we haven't cut a release lately, but you can see the commands in the most recent docs:

flake8 --max-line-length=100 --extend-ignore=E203,W503 parsons black parsons

elyse-weiss commented 1 year ago

@Jason94 let me know how I can point this toward the major release

elyse-weiss commented 1 year ago

@Jason94 can you confirm I didn't mess anything up when I merged conflicts?

shaunagm commented 1 year ago

Let's get this landed. I think per our discussion on Slack, this doesn't actually need to target the major release. @elyse-weiss, can you confirm that the method you're altering, drop_dependencies_for_cols, is not exposed in the documentation, and that the methods that do call it say that the drop cascades, even though it currently doesn't?

elyse-weiss commented 1 year ago

Yes, this change is in line with current documentation.

shaunagm commented 1 year ago

Okay, great! Can you update this to point back to main instead of major release, then? Sorry for the back-and-forth and accompanying delay.

elyse-weiss commented 1 year ago

done! should I go ahead and merge?

shaunagm commented 1 year ago

Yup, we're good to go!