search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
261 stars 132 forks source link

Specify version of slackclient in setup.py #825

Closed crayolakat closed 1 year ago

crayolakat commented 1 year ago

When running pip install parsons[slack], the latest version of slackclient is installed (2.9.4). The version of slackclient specified in requirements.txt is 1.3.0: https://github.com/move-coop/parsons/blob/853b27cb14394daaf113b88718facfde1190a572/requirements.txt#L6

In slackclient 2.9.4, the slackclient module has been renamed, causing all references to parsons/notifications/slack.py to return the error ModuleNotFoundError: No module named 'slackclient'. https://github.com/move-coop/parsons/blob/853b27cb14394daaf113b88718facfde1190a572/parsons/notifications/slack.py#L7

This PR specifies the slackclient version in setup.py to be the same version specified in requirements.txt.

shaunagm commented 1 year ago

Thanks, @crayolakat! Tagging in @cmc333333 to help review this one.