search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
259 stars 131 forks source link

added encoding to s3_copy function in redshift class #827

Closed sharinetmc closed 3 months ago

shaunagm commented 1 year ago

So the instructions for how to use Black in the docs are wrong, whoops. Can you try black --check parsons/ test/ useful_resources/

shaunagm commented 5 months ago

@sharinetmc can you double-check that I resolved the merge conflict correctly and that the function does what it should? https://github.com/move-coop/parsons/pull/827/commits/0fb5ab3ee3d21e9e72a59a81e6b9ed93c1888e87

If you can confirm that, we can merge this

sharinetmc commented 3 months ago

@shaunagm, tests are all passing now and everything looks good!