search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
259 stars 131 forks source link

Add support for deleting person from NGPVAN #834

Closed sjwmoveon closed 1 year ago

shaunagm commented 1 year ago

@sjwmoveon is this ready for review? Did you want @crayolakat to review or someone else from the team?

Also, the tests are failing on the linting stage. You should be able to run Black to fix any issues. Instructions are here: https://move-coop.github.io/parsons/html/stable/contributing.html#linting

sjwmoveon commented 1 year ago

@shaunagm this is ready for review, sorry for the delay!

I actually see the build failing on the install dependencies step, with the error Error: [Errno 2] No such file or directory: '/home/circleci/project/venv/bin/python3'. Is that something I need to fix on my end or is it some kind of issue with the CI tool?

shaunagm commented 1 year ago

Oh sigh. That's a recurring and highly annoying CircleCI error that requires us to update the whole repository to "burst" the cache keys. I will try to get to that early next week. I believe once that's settled you'll still have the linting issue though.

shaunagm commented 1 year ago

Looks like the CircleCI thing is fixed, and there's another linting issue:

Screenshot from 2023-06-20 14-13-25

shaunagm commented 1 year ago

One more linting step! Can you run Black? It's new in Parsons and should make linting easier in the future, instructions here: https://move-coop.github.io/parsons/html/stable/contributing.html#linting

sjwmoveon commented 1 year ago

I've run Black, thank you for your patience as I figure out linting!

shaunagm commented 1 year ago

@sjwmoveon no worries, linting is a pain! hopefully Black will make it easier for all of us