Currently, ActionNetwork Connector handles "custom fields" by just uploading all extra keyword args as custom fields. While this works, it's poor design as it makes updating ActionNetwork data implicit rather than explicit, and it means that adding future keyword args can risk breaking use cases if those keyword arguments happen to overlap with a particular user's custom fields.
Instead, custom fields should need to be explicitly defined by the user when uploading.
Possible Implementation
This should be simply removing the **kwargs in upsert_person and adding custom_fields. Unfortunately, this would not be a backwards-compatible change. It's probably possible to set this on a deprecation path and add other keyword arguments and warnings.
Currently, ActionNetwork Connector handles "custom fields" by just uploading all extra keyword args as custom fields. While this works, it's poor design as it makes updating ActionNetwork data implicit rather than explicit, and it means that adding future keyword args can risk breaking use cases if those keyword arguments happen to overlap with a particular user's custom fields.
Instead, custom fields should need to be explicitly defined by the user when uploading.
Possible Implementation
This should be simply removing the **kwargs in upsert_person and adding
custom_fields. Unfortunately, this would not be a backwards-compatible change. It's probably possible to set this on a deprecation path and add other keyword arguments and warnings.Priority
Medium priority.