search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
258 stars 128 forks source link

add script #845

Closed sharinetmc closed 2 months ago

sharinetmc commented 1 year ago

Hmm...interesting. I just ran black again and it said that the file was left unchanged.

shaunagm commented 1 year ago

Can you share the full output of the Black command, as well as the location you're running the command from?

sharinetmc commented 1 year ago

(parsons) ➜ parsons git:(sample_ngpvan_printed_list) black useful_resources/sample_code/ngpvan_sample_printedlist.py All done! ✨ 🍰 ✨ 1 file left unchanged.

shaunagm commented 1 year ago

So the instructions for how to use Black in the docs are wrong, whoops. Can you try black --check parsons/ test/ useful_resources/

shaunagm commented 4 months ago

Thanks for the help @bmos but this PR is now including 3 extra files which it shouldn't need to touch. Any idea why/how to fix?

bmos commented 4 months ago

Afaik that is because it was needed to get the linting check to pass. You can see the checks on the two commits in my PR. Log from before including the sphinx docs related commit: https://github.com/move-coop/parsons/runs/22737528175 Log from after including that commit: https://github.com/move-coop/parsons/runs/22737929377

bmos commented 4 months ago

Now that you have updated the branch to main, it's using the new tooling which targets a longer line-length. I can re-format in the next few days.

shaunagm commented 4 months ago

It's probably easier for Sharine to just redo with a new PR off the most recent main branch. It's easy enough since it's a single file, and then she can run Black which will use whatever the current standards are.

sharinetmc commented 3 months ago

@shaunagm this is done! finally lol