move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
258 stars 128 forks source link

NewMode - Add bulk `targets` endpoint #857

Closed IanRFerguson closed 1 year ago

IanRFerguson commented 1 year ago

This PR adds an additional GET request to the NewMode client that allows ALL targets to be queried and returned as a table. The addition of this function will give Parsons users flexibility in their API requests to NewMode, as they may be interested in exploring target data broadly and across outreaches.


willyraedy commented 1 year ago

@ydamit looks like there might be some linting / formatting errors from the action builder connector. Would you mind taking a look at that so we can get the build to run here?

ydamit commented 1 year ago

@willyraedy , I'll do my best! Am I using criteria from black or flake8?

willyraedy commented 1 year ago

@willyraedy , I'll do my best! Am I using criteria from black or flake8?

If you click the "Details" link in the build step above, it should show you the errors.

image

shaunagm commented 1 year ago

If you update your branch, it should get rid of those linting errors since they've been fixed on main as of this morning.

ydamit commented 1 year ago

@willyraedy , gotcha. So it sounds like we're just moving over to black, since it looks like part of the issue is that some of the docstrings that go long are decorated with noqa for flake8 purposes, but black doesn't seem to like that?

ydamit commented 1 year ago

Oh nevermind, then!

willyraedy commented 1 year ago

@IanRFerguson did you see that? Sounds like you just need to re-merge latest from main here

IanRFerguson commented 1 year ago

@shaunagm @willyraedy Checks passing! ready for another look when y'all have time