search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
260 stars 132 forks source link

BigQuery - Add row count function to connector #913

Closed IanRFerguson closed 10 months ago

IanRFerguson commented 11 months ago

Adds a get_row_count function to the BigQuery connector. The native version of this function in the BigQuery API client only works with tables, wondering if we should stick with that logic here and add another function for views

shaunagm commented 11 months ago

I will defer to Willy etc on matters of substance, such as how to handle views. The only change I'd like to see is a test for the new method, otherwise lgtm.

shaunagm commented 10 months ago

Just want to flag that PRs against major-release don't have tests run. I'm going to try and fix that next week, but leaving a comment here to double-check that tests are run before this is merged.

willyraedy commented 10 months ago

Just want to flag that PRs against major-release don't have tests run. I'm going to try and fix that next week, but leaving a comment here to double-check that tests are run before this is merged.

I think we set that up! Seems like they're running on this PR. Do you have more concerns here?