search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
257 stars 125 forks source link

Generalize the oauth_api_connector to accept authorization kwargs #918

Closed austinweisgrau closed 4 months ago

austinweisgrau commented 8 months ago

The oauth_api_connector can simplify authorization with APIs that use OAuth2, but requires some modifications to be general enough to work with different implementations of OAuth2.

This PR enables the use of authorization kwargs that are passed to authorization endpoints when requesting a token. The updated connector is then implemented in the Zoom connector as a test / demonstration.

Someone who has Zoom credentials should check if this update works.

Prior to this PR, the only connector that used the oauth_api_connector is the controlshift connector. That one should be unaffected, because the new argument is optional and doesn't change behavior if it is not used.

This should be tested by folks who have credentials with all three directly affected connectors:

austinweisgrau commented 8 months ago

Rebasing onto main and adding a commit that updates the catalist match connector to also use the oauth_api_connector

austinweisgrau commented 8 months ago

This is verified to work with the Catalist Match connector

shaunagm commented 5 months ago

This works on Zoom! Checked the checkbox - now we just need ControlShift tested and we'll be good to merge.