search

move-coop / parsons

A python library of connectors for the progressive community.
Other
255 stars 125 forks source link

Resolve GCP Test Failures For Major Release #948

Closed IanRFerguson closed 7 months ago

IanRFerguson commented 7 months ago

There are several unit tests that are failing for new GCP connectors - this PR resolves those test failures in preparation for major release

IanRFerguson commented 7 months ago

I'm going to keep updating the docs but all tests are passing locally now @willyraedy

austinweisgrau commented 7 months ago

Wait why are these tests passing without the fix to the google storage_transfer import? I can't get this to work locally...

IanRFerguson commented 7 months ago

Wait why are these tests passing without the fix to the google storage_transfer import? I can't get this to work locally...

uh oh ... you're seeing the same ImportError we were dealing with before?

austinweisgrau commented 7 months ago

locally yeah but something weird is going on - maybe just for me? - github actions clearly doesnt have an issue with anything here

austinweisgrau commented 7 months ago

Ah it works if you do pip install -r requirements.txt (which the github actions tests do) but not if you do PARSONS_LIMITED_DEPENDENCIES=1 pip install .[google]

Something in the dependency versions...

austinweisgrau commented 7 months ago

Got it - the google-cloud-storage-transfer wasn't included as a dependency in the extras for parsons[google] in the setup.py file.

Fixed that here: https://github.com/move-coop/parsons/pull/946

austinweisgrau commented 7 months ago

The tests passed in github actions but failed for me locally due to a misconfiguration of the test environment, see this PR which addresses that