search

move-coop / parsons

A python library of connectors for the progressive community.
https://www.parsonsproject.org/
Other
260 stars 132 forks source link

BigQuery - Call .result() regardless of compression #974

Closed IanRFerguson closed 7 months ago

IanRFerguson commented 8 months ago

We found that some of the try/except/finally logic employed in the GoogleBigQuery connector is suppressing exceptions. This PR explicitly returns a LoadJobConfig object when a flat file is forcibly decompressed, such that any errors raised are encountered in the try block

shaunagm commented 8 months ago

This looks good to me. No problems with the tests - just the issue with the Sphinx versioning that still needs to be fixed (not an issue with this PR)