Closed bear-jordan closed 1 month ago
Hi, looked into why the Mac build is failing (see here). Github isn't reporting any outages — not too sure what is going on
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: Operation timed out (codeload.github.com:443)
Warning: Back off 26.77 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (codeload.github.com:443)
Warning: Back off 21.133 seconds before retry.
Error: Operation timed out (api.github.com:443)
Hi, looked into why the Mac build is failing (see here). Github isn't reporting any outages — not too sure what is going on
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: Operation timed out (codeload.github.com:443) Warning: Back off 26.77 seconds before retry. Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (codeload.github.com:443) Warning: Back off 21.133 seconds before retry. Error: Operation timed out (api.github.com:443)
Sometimes this happens with these mac tests :'( I'm rerunning it and hopefully it'll pass.
Ominous that it's a timeout error 😂
Looks like the tests are passing now! What's the status of this PR? Are we waiting on re-review, or on changes?
I might have missed something, but I think all changes have been addressed.
Awesome! @Jason94 whenever you get a chance can you re-review?
Overview
This PR addresses Issue #910. A timeout is added to prevent indefinite hanging.
From the original issue:
Changes
27/1/2024
AddedMAX_TIMEOUT = 30
constantUpdatedload_job.result()
to useMAX_TIMEOUT
31/1/2024 — @Jason94
max_timeout: int = 30
as a keyword argumentload_job.result()
to usemax_timeout
DeadlineExceeded
error handling (docs)