search

move-coop / parsons

A python library of connectors for the progressive community.
Other
255 stars 125 forks source link

Allow Table(None) #984

Open austinweisgrau opened 5 months ago

austinweisgrau commented 5 months ago

This change allows Table(None) to work, equivalent to Table(). This is reasonable behavior and also simplifies the implementation to avoid the necessity of a sentinal as a default argument.

This may be a breaking change if code depends on Table(None) raising a ValueError.

austinweisgrau commented 5 months ago

Just one commit here, which will be more clear once major-release is brought up to date. no urgency on my end there.

Jason94 commented 4 months ago

I think this change makes sense, and I took a look at the operative commit (https://github.com/move-coop/parsons/pull/984/commits/62ceca67a32bffc3dcacec4653a5c04c7f398102) and it looks good to me.

shaunagm commented 4 months ago

Sorry about the delay - there's a merge conflict in major-release so it can't be trivially merged back into main. I've asked Willy and Kasia to look into it, and hopefully we'll have that handled (and this PR merged) within the week.