if C3 in nav mode move speed and turn icons to left side of screen

move-fast / openpilot

openpilot is an open source driver assistance system. openpilot performs the functions of Automated Lane Centering and Adaptive Cruise Control for over 85 supported car makes and models.

https://comma.ai/

MIT License

21 stars 3 forks source link

if C3 in nav mode move speed and turn icons to left side of screen #8

Closed twilsonco closed 3 years ago

twilsonco commented 3 years ago

Template: Bug fix

Description [](A description of the bug and the fix. Also link any relevant issues.)

Speed limit and turn speed icons overlap with speed indicator when C3 is in nav mode, so I move them to the left side of the screen when in nav mode, based on canvas aspect ratio

Verification [](Explain how you tested this bug fix.)

It looks good now :)

alfhern commented 3 years ago

Thanks for the pull request, we will integrate it but we have discussed and will then moving permanently to the left. Is not so nice if it jumps from one place to another when the navigation UI jumps in.

alfhern commented 3 years ago

Implemented on release_0.8.9

twilsonco commented 3 years ago

Good move. I concur.