search

move-language / move

Apache License 2.0
2.24k stars 677 forks source link

add highlight for book and translation #1049

Closed YusongWang closed 11 months ago

YusongWang commented 1 year ago

Motivation

add highlight for book

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No code change

YusongWang commented 1 year ago

@wrwg @jolestar can somebody review this change and let me merge?

wrwg commented 1 year ago

Adding some Chinese speakers

jolestar commented 1 year ago

@geometryolife help to review.

vgao1996 commented 1 year ago

The changes (both English & Chinese) look good to me.

Also happy to see the syntax highlighter being added. It looks like the highlighter is generated by some tool. Would you mind sharing what that tool is? Wonder if we could also include the original highlighter rules in the repo.

YusongWang commented 1 year ago

The changes (both English & Chinese) look good to me.

Also happy to see the syntax highlighter being added. It looks like the highlighter is generated by some tool. Would you mind sharing what that tool is? Wonder if we could also include the original highlighter rules in the repo.

The repo is here highlightjs-move, i'm not put any readme yet. this repo is a plug-in for highlight.js and only have one file call move.js. the rules here

YusongWang commented 1 year ago

@vgao1996 @geometryolife Hey guys, can somebody approving this?

YusongWang commented 1 year ago

@wrwg Hey man, can you trigger wf again?