search

move-language / move

Apache License 2.0
2.24k stars 676 forks source link

[Dwarf] New language name for Move #1080

Open ksolana opened 8 months ago

ksolana commented 8 months ago

As move->llvm compiler is in the works. There is a need to have Dwarf attribute supporting move programming language.

As per https://dwarfstd.org/languages.html: "Between revisions of the Standard, new language codes may be requested by submitting a request on the Public Comment page."

It can be based on a recent request by Mojo: https://dwarfstd.org/issues/230502.1.html

ksolana commented 8 months ago

@jcivlin FYI

wrwg commented 8 months ago

Sounds like a great idea. We discuss at the next Move community meeting, I think you, Mysten, Aptos and other can co-sign this. I can work on the form after we discussed.

@sblackshear

jcivlin commented 8 months ago

We need a new value LLVMDWARFSourceLanguage::LLVMDWARFSourceLanguageMove likewise llvm to support and generate Dwarf info for all Move language constructs.

wrwg commented 8 months ago

We need a new value LLVMDWARFSourceLanguage::LLVMDWARFSourceLanguageMove likewise llvm to support and generate Dwarf info for all Move language constructs.

Can you link to/quickly describe whats the difference, meaning wise and process wise? Can we get both with one request?

ksolana commented 8 months ago

There are two steps

  1. Email dwardstd https://dwarfstd.org/languages.html as mentioned in the issue description.
  2. Once that is approved, put a patch to llvm-project with an entry like LLVMDWARFSourceLanguage::LLVMDWARFSourceLanguageMove

1 needs to happen first. But we can do the changes in our internal llvm fork with second part to make progress.

ksolana commented 7 months ago

I haven't. Please go ahead.

On Tue, Nov 14, 2023 at 6:56 AM Sam Blackshear @.***> wrote:

@ksolana https://github.com/ksolana, have you done step (1)? I am happy to send an email if not

— Reply to this email directly, view it on GitHub https://github.com/move-language/move/issues/1080#issuecomment-1810384527, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2NVJBB5AMRU3U6IDYEPMM3YEOBCXAVCNFSM6AAAAAA6JZNGXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGM4DINJSG4 . You are receiving this because you were mentioned.Message ID: @.***>

wrwg commented 5 months ago

Looks like we dropped the ball on this. Is it still a thing?

ksolana commented 5 months ago

Yeah, we are expecting the move language designers to propose this to the DWARF committee.

ksolana commented 4 months ago

Requested by Wolfgang: https://lists.dwarfstd.org/pipermail/dwarf-discuss/2024-February/002361.html