search

move-language / move

Apache License 2.0
2.25k stars 684 forks source link

[printing] fix bug in StructTag::struct_to_canonical_string #918

Closed sblackshear closed 1 year ago

sblackshear commented 1 year ago

Previously, a type instantiation w/ >1 type parameters was printed without a comma separator (e.g., S<u64bool> instead of S<u64,bool>for S<T1,T2> instantiated with u64 and bool). This PR adds a comma separator and a test.

(reported in https://github.com/move-language/move/issues/916)

Adding Aptos folks as reviewers to advise on whether this fix is ok as-is or creates a breaking change that should be managed.

alinush commented 1 year ago

I'll have to check when I get back home. From a quick glance, I don't remember if I implemented that function or not.

alinush commented 1 year ago

Indeed, not related to my work; see my (unrelated) changes to language_storage.rs here.

So LGTM