search

moveit / geometric_shapes

Representation of geometric shapes
57 stars 92 forks source link

Fix cmake such that Boost::filesystem is exported properly #205

Closed jlack1987 closed 2 years ago

jlack1987 commented 3 years ago

This fixes https://github.com/ros-planning/geometric_shapes/issues/166. Ultimately this issue result in the Boost components not getting exported with an ament_target_dependencies and ament_export_dependencies calls.

Before this fix attempting to link against this pkg resulted in,

Target "mylib" links to target "Boost::filesystem"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?

After this fix it builds properly.

jlack1987 commented 2 years ago

@henningkayser I went ahead and fixed the file name, but I don't think that file should be included. Is there somewhere else you have seen that does this?

jlack1987 commented 2 years ago

Is there any chance this could get cherry picked into foxy/galactic since it's a bug that makes it tough to use this package?

JafarAbdi commented 2 years ago

For some reason, GitHub decided to merge this PR by me only pushing to your branch :/

JafarAbdi commented 2 years ago

@jlack1987 Do you mind testing the latest ros2 branch .?

JafarAbdi commented 2 years ago

Is there any chance this could get cherry picked into foxy/galactic since it's a bug that makes it tough to use this package?

Yep, I'll do right now