moveit / geometric_shapes

Representation of geometric shapes

57 stars 92 forks source link

2.1.1 (Foxy) #213

Closed tylerjw closed 2 years ago

tylerjw commented 2 years ago

This is a problem because 2.1.1 was released for Rolling and Galactic but never for foxy. I'm not sure what to do about that as we should probably release these changes into foxy.

codecov[bot] commented 2 years ago

Codecov Report

Merging #213 (902dadd) into foxy (3e7e23d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             foxy     #213   +/-   ##
=======================================
  Coverage   54.66%   54.66%           
=======================================
  Files          11       11           
  Lines        2031     2031           
=======================================
  Hits         1110     1110           
  Misses        921      921

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e7e23d...902dadd. Read the comment docs.

rhaschke commented 2 years ago

Why do you need a separate foxy branch at all? As far as I can see (but I checked a few files only), the code differences are limited to the copyright notice. What about simply merging and continuing with a singly ros2 branch?

tylerjw commented 2 years ago

Based on the email I got from the buildfarm it is yet another one of the .h/.hpp incldes. I'm going to make a PR against the ros2 branch that should make this build for foxy.

henningkayser commented 2 years ago

Based on the email I got from the buildfarm it is yet another one of the .h/.hpp incldes. I'm going to make a PR against the ros2 branch that should make this build for foxy.

Maybe we were a little to fast with creating these branches. In the future they might still be useful, and syncing the changes here should be trivial.

tylerjw commented 2 years ago

@henningkayser look at the other PR for adding support for Foxy to the ros2 branch. I think we should close this as it has a SemVar issue and we should be able to release from R/G/F all from the ros2 branch after that other PR. Then after the release is synced we can delete this branch (buildfarm doesn't keep old versions anyway).

henningkayser commented 2 years ago

@henningkayser look at the other PR for adding support for Foxy to the ros2 branch. I think we should close this as it has a SemVar issue and we should be able to release from R/G/F all from the ros2 branch after that other PR. Then after the release is synced we can delete this branch (buildfarm doesn't keep old versions anyway).

Yeah, just wanted to say that I noticed the other one right now ;)