search

moveit / moveit

:robot: The MoveIt motion planning framework
http://moveit.ros.org
BSD 3-Clause "New" or "Revised" License
1.67k stars 948 forks source link

Use the new API for providing a RNG to make some test results more consistent #2851

Open tylerjw opened 3 years ago

tylerjw commented 3 years ago

Background

Use the API for providing an RNG to make some test results more consistent: https://github.com/ros-planning/moveit/pull/2799#issuecomment-907290334

akshay1580 commented 3 years ago

I am new to open source can anyone guide me how to start :)

PeterMitrano commented 3 years ago

Hi akshay! Start by reading this page https://moveit.ros.org/documentation/contributing/ Then you can start working on your pull request to address this issue. It should be small, adding only the new test(s) for the specific RNG API discussed in #2799. You should see that the tests pass, that they test the right behavior, and that all the code is formatted correctly.

Definitely look at other PRs for example of how to write a good PR. Also consider posting on ros answers or the moveit discord.

Romit-Mohanty-1 commented 3 years ago

Hi, Is this issue still open & can I contribute to this issue? Please guide me, I am a newbie.

skd28 commented 2 years ago

hi,can i contribute to this issue?

tylerjw commented 2 years ago

I am new to open source can anyone guide me how to start :)

Hi, Is this issue still open & can I contribute to this issue? Please guide me, I am a newbie.

hi,can i contribute to this issue?

@akshay1580 @Romit-Mohanty-1 @skd28 where are you guys coming from? We welcome new contributors however as this is an open-source project you should start by reading the documentation of the project and observing the norms of the community through github. Is there something more specific you want to know?

I'm a bit confused by the messages that you (and others) are posting on issues like this and then disappearing. How did you find this project and this issue? What exactly do you expect to get as a response to your questions?

rajbhoyar729 commented 2 years ago

is this issue still open or not

tylerjw commented 2 years ago

is this issue still open or not

It is, but I'm not really sure it is a good-first-issue. To close this issue you'll need to figure out what parts of the tests rely on randomness and seed the rng to make the test results more consistant.

rajbhoyar729 commented 2 years ago

Ok sir On Mon, 20 Dec 2021, 08:22 Tyler Weaver, @.***> wrote:

is this issue still open or not

It is, but I'm not really sure it is a good-first-issue. To close this issue you'll need to figure out what parts of the tests rely on randomness and seed the rng to make the test results more consistant.

— Reply to this email directly, view it on GitHub https://github.com/ros-planning/moveit/issues/2851#issuecomment-997547615, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUMJCDIJ5BFH4TYMGHKURODUR2K5PANCNFSM5C543PIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>