moveit / moveit2

:robot: MoveIt for ROS 2
https://moveit.ai/
BSD 3-Clause "New" or "Revised" License
1.06k stars 516 forks source link

Fix moveit_msg spelling of Aquire to Acquire. #1787

Open azalutsky opened 1 year ago

azalutsky commented 1 year ago

Is your feature request related to a problem? Please describe. It is a non-issue beyond OCD people being disappointed in a spelling.

Describe the solution you'd like moveit::planning_interface::MoveItErrorCode:: UNABLE_TO_AQUIRE_SENSOR_DATA -> moveit::planning_interface::MoveItErrorCode:: UNABLE_TO_ACQUIRE_SENSOR_DATA

Describe alternatives you've considered Changing the spelling of acquire in the dictionary to aquire.

Additional context image

I believe the biggest problem with this fix is it requires not only a modification in moveit_msgs but in many repositories as well. I'd just like some direction on how to achieve this.

tylerjw commented 1 year ago

If you provide a PR to both moveit_msgs and moveit2 itself with adding your pr to the moveit2.repos file here the PR can test your change. Then we can merge the moveit_msgs change and then the moveit2.repos change can be updated to point at the moveit_msgs repo after your change. At the next release, we'll release them together and users will get both changes at once.

I believe that would work and is hopefully not too much trouble. Good catch on the spelling.

azalutsky commented 1 year ago

Thanks @tylerjw , I'll get that in.

sameergupta4873 commented 1 year ago

@tylerjw I would like to work on this issue, according to the above discussion, I broke the issue into few steps:-

AtharvSabde commented 1 year ago

@tylerjw I would like to work on this issue

github-actions[bot] commented 1 year ago

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.