search

moveit / moveit2

:robot: MoveIt for ROS 2
https://moveit.ai/
BSD 3-Clause "New" or "Revised" License
1.06k stars 516 forks source link

Remove topic name parameters in favor of const topic names #2714

Closed sjahr closed 2 months ago

sjahr commented 7 months ago

In multiple places of moveit2 (for example moveit_cpp), topic names can be configured with a parameter. This is not necessary because remapping topics on launch file level is trivial and the parameter API can be simplified by removing these parameters. Instead of having the topic names configurable with a ROS 2 parameters we should just use a const name in the cpp code.

yash-011 commented 7 months ago

first issue was good

Gaurang-1402 commented 6 months ago

Hi @sjahr I have made a PR to the moveit2 repo that resolves this issue: https://github.com/ros-planning/moveit2/pull/2777

I'm curious to hear your feedback and improvise!