moveit / moveit2

:robot: MoveIt for ROS 2
https://moveit.ai/
BSD 3-Clause "New" or "Revised" License
1.05k stars 513 forks source link

Fix error message text about invalid servo parameters (backport #2769) #2771

Open mergify[bot] opened 6 months ago

mergify[bot] commented 6 months ago

Description

Was debugging something and realized this error message is swapped.

I'll add this later when I'm on a dev computer, but looks like we should also add a check for if ((servo_params.command_out_type == "std_msgs/Float64MultiArray") && !servo_params.publish_joint_positions && !servo_params.publish_joint_velocities) - The previous check would not trigger that as it is specific to Float64 type.

Checklist


This is an automatic backport of pull request #2769 done by Mergify.

mergify[bot] commented 6 months ago

Cherry-pick of df78880a0230dbcf0ad06833d91f2c3d70d9bec3 has failed:

On branch mergify/bp/iron/pr-2769
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit df78880a0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   moveit_ros/moveit_servo/src/servo.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

github-actions[bot] commented 4 months ago

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.