moveit / moveit2

:robot: MoveIt for ROS 2
https://moveit.ai/
BSD 3-Clause "New" or "Revised" License
988 stars 494 forks source link

Removing topic name parameter configuration and replacing with const strings #2777

Open Gaurang-1402 opened 3 months ago

Gaurang-1402 commented 3 months ago

Description

This PR introduces changes to streamline the setup process for the moveit_cpp::PlanningSceneMonitorOptions and moveit_servo::ServoParameters by utilizing constant strings for topic names instead of parameter-based configurations. The changes ensure that topic names are now consistent and predefined. This modification also implies that users who need customized topic names will now have to use topic remapping in their launch files or at the ROS node level.

These updates are in direct response to the issue discussed in #2714

Checklist

mergify[bot] commented 3 months ago

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

github-actions[bot] commented 1 month ago

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

henningkayser commented 1 month ago

@Gaurang-1402 what's the current status of this PR? It would also be great if you could target the 'main' branch. We can backport fixes and non-breaking changes to 'humble'