search

moveit / moveit2

:robot: MoveIt for ROS 2
https://moveit.ai/
BSD 3-Clause "New" or "Revised" License
988 stars 494 forks source link

CI: Allow non-interactive installation of rmw-connextdds #2790

Closed rhaschke closed 3 months ago

rhaschke commented 3 months ago

When installing rmw-connextdds within a humble docker image, e.g. via rosdep, this fails, because interactive acceptance of the license is required despite common flags like --yes: https://github.com/ros-planning/moveit_task_constructor/issues/558 https://github.com/ros-planning/moveit_task_constructor/actions/runs/8680352798/job/23800710624#step:4:177

Declaring the environment variable RTI_NC_LICENSE_ACCEPTED=yes resolves that issue: https://github.com/ros-planning/moveit_task_constructor/actions/runs/8680352798

mergify[bot] commented 3 months ago

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

sea-bass commented 3 months ago

Should this target main, as the bot says?

rhaschke commented 3 months ago

Should this target main, as the bot says?

I don't know whether main/rolling is also affected by this issue. Currently, the rolling CI is broken for other reasons. Thus, I explicitly targeted humble. I suggest to forward-port if needed. Obviously, ikfast testing is broken here as well - due to outdated server keys. Does anybody maintain CI?

rhaschke commented 3 months ago

Obviously, ikfast testing is broken here as well - due to outdated server keys.

I have a fix for this from MoveIt 1.