search

moveit / moveit2

:robot: MoveIt for ROS 2
https://moveit.ai/
BSD 3-Clause "New" or "Revised" License
1.1k stars 531 forks source link

Prefer double to float, But Test First #873

Open tylerjw opened 2 years ago

tylerjw commented 2 years ago

https://github.com/cpp-best-practices/cppbestpractices/blob/master/08-Considering_Performance.md#prefer-double-to-float-but-test-first

dpbnasika commented 1 year ago

hey tyler, i want to work on this.:), give me some guidelines..:)

tylerjw commented 1 year ago
  1. read the guideline
  2. find places in moveit it can be applied
  3. try applying it and test those changes in some way
  4. open a pr with the changes and explain how you tested it to make sure it didn't break the existing behavior; bonus points if you add new automated tests