search

moveit / moveit2

:robot: MoveIt for ROS 2
https://moveit.ai/
BSD 3-Clause "New" or "Revised" License
1.09k stars 528 forks source link

Main CI is broken after moveit_resources PR 101 #887

Closed vatanaksoytezer closed 2 years ago

vatanaksoytezer commented 2 years ago

After https://github.com/ros-planning/moveit_resources/pull/101/files, which introduces moveit_core dependency in prbt_ikfast_manipulator_plugin package. That causes CI failures in main branch, as upstream workspace is isolated from the target workspace (in this case) MoveIt 2. We should remove this dependency if not needed, but if the dependency is acutally needed we should probably make that package a separate repository.

vatanaksoytezer commented 2 years ago

Upon further investigation I think prbt_ikfast_manipulator_plugin should be moved under moveit_kinematics if there are no license issues. Also this plugin should be not a dependency of prbt_pg70_support to avoid circular depdendencies.