search

moveit / moveit_calibration

Hand-eye calibration tools for robot arms.
BSD 3-Clause "New" or "Revised" License
143 stars 79 forks source link

Support rational polynomial distortion #80

Closed JStech closed 7 months ago

JStech commented 3 years ago

Adds support for rational polynomial distortion model, and no distortion model. Fixes #77.

JStech commented 3 years ago

@tylerjw CI is failing to find the catkin CMake package . . . huhwhat

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (828eaae) into master (034f951) will decrease coverage by 0.12%. The diff coverage is 71.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   72.75%   72.63%   -0.11%     
==========================================
  Files          10       10              
  Lines         554      559       +5     
==========================================
+ Hits          403      406       +3     
- Misses        151      153       +2
Impacted Files Coverage Δ
...t/handeye_calibration_target/handeye_target_base.h 79.69% <71.43%> (-0.80%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 034f951...828eaae. Read the comment docs.

will-44 commented 1 year ago

Thank you for your PR ! You save my day !! (could it be merged ?)

JStech commented 1 year ago

Thank you for your PR ! You save my day !! (could it be merged ?)

You're welcome, and yes, I think it can be merged. @jliukkonen has a couple open comments that I never got around to, but since they're style rather than function, I'd rather just merge this as is. I don't have a working ROS 1 environment to test in at the moment.

0smile commented 7 months ago

Hi! I want to have a quick ask that if this PR works for Noetic, or has this PR been merged to master brach? Since the master brach seems not work on rational distortion model and this PR print following error under Noetic: [ERROR] [1713252613.733280436]: PluginlibFactory: The plugin for class 'moveit_rviz_plugin/HandEyeCalibration' failed to load. Error: According to the loaded plugin descriptions the class moveit_rviz_plugin/HandEyeCalibration with base class type rviz::Display does not exist.