search

moveit / moveit_core

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
31 stars 76 forks source link

Kinematic base updates #259

Closed jrgnicho closed 9 years ago

jrgnicho commented 9 years ago

Reinstated the PR for extending the KinematicsBase interface as described in this PR #231 @sachinchitta please review.

davetcoleman commented 9 years ago

Is this the same PR that has already been merged into the jade-devel branch?

jrgnicho commented 9 years ago

@davetcoleman , yes but I had to recreate it since I had deleted the fork from which the PR had been originated.

davetcoleman commented 9 years ago

It looks good, but I can't exactly remember - did we agree to also add these changes back into indigo?

jrgnicho commented 9 years ago

Yes, I believe so. In fact I remember being tasked with verifying that the changes didn't break any old (indigo) ikfast implementations.