recent merge #259 breaks indigo build

moveit / moveit_core

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit

31 stars 76 forks source link

recent merge #259 breaks indigo build #260

Closed rhaschke closed 9 years ago

rhaschke commented 9 years ago

The recent merge of PR #259 performed by @davetcoleman breaks indigo build: The addition of the new KinematicsQueryOption KinematicsQueryOptions in kinematics_base.h is not mirrored by a change in moveit_ros/robot_interaction/.../kinematic_options.cpp causing the static assert to fail. The jade-devel branch has the appropriate changes.

shaun-edwards commented 9 years ago

@jrgnicho, can you verify and fix this issue?

shaun-edwards commented 9 years ago

There is still an open PR that needs to be merged to fix this: ros-planning/moveit_ros#617. It was opened along with the PR #259, but it wasn't merged. @davetcoleman, can you review and merge?

davetcoleman commented 9 years ago

Not sure if we should merge #617 or revert this - @sachinchitta wanted to review #259 for indigo

davetcoleman commented 9 years ago

it has been merged https://github.com/ros-planning/moveit_core/pull/259