search

moveit / moveit_core

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
31 stars 76 forks source link

planning_scene updates: expose success state to caller #297

Closed v4hn closed 8 years ago

v4hn commented 8 years ago

This is required to get the information back for the ApplyPlanningSceneService.

This is required for https://github.com/ros-planning/moveit_ros/pull/686

As it turns out, according to abi-compliance-checker these changes are also ABI compliant... I didn't expect that.

130s commented 8 years ago

Looks like this is already cherry-picked into jade-devel https://github.com/ros-planning/moveit_core/commit/702c3e75b7f1cf79c2096d8cf5466f614b830a07 w/o PR.

v4hn commented 8 years ago

Yes. When I asked about a cherry-pick policy dave replied that it's fine to pick merged commits to newer branches without PR here. Would you prefer to have a PR for each cherry-pick @130s ?

130s commented 8 years ago

@v4hn Yeah I think so,,,although I know it's cumbersome. As I commented https://github.com/ros-planning/moveit_core/pull/301#issuecomment-229156460, currently I don't know an easy, cleaner way to find commits that need synced to other branches, and going through PRs is robust enough I think. Suggestion is much welcomed.

v4hn commented 8 years ago

https://github.com/ros-planning/moveit_core/pull/301#issuecomment-229187056 for reference. Let's continue this over there.

davetcoleman commented 8 years ago

I still think if you just had a PR merged and you want to reflect it in a newer branch, its no big deal to cherry-pick and commit it without a commit. I say its fine because its what I've seen others do here and it makes sense to me. I created those PRs for syncing in the past day because they were old and messy and potential error-prone. I think we should just do a better job of always keeping the branches in sync