search

moveit / moveit_docs

DEPRECATED - see https://github.com/ros-planning/moveit.ros.org
5 stars 10 forks source link

moveit.rosinstall for indigo-devel #21

Closed coolvision closed 8 years ago

coolvision commented 10 years ago

moveit.rosinstall for indigo-devel uses hydro-devel packages. there is no difference between indigo-devel/moveit.rosinstall and hydro-devel/moveit.rosinstall, https://github.com/ros-planning/moveit_docs/blob/hydro-devel/moveit.rosinstall https://github.com/ros-planning/moveit_docs/blob/indigo-devel/moveit.rosinstall

should indigo-devel/moveit.rosinstall use indigo-devel versions for the packages that have indigo branches? i found it to be a problem while installing from source with rosinstall.

davetcoleman commented 10 years ago

Yes, it should. Could you submit a patch please?

coolvision commented 10 years ago

ok, after I will be able to successfully build it all from source (there are some problems with indigo-devel branch for moveit-ros) what do you think about this one: https://github.com/ros-planning/moveit_ros/issues/494

davetcoleman commented 10 years ago

also... I don't see a pull request for this yet. we need everyone to contribute in order for the open source moveit project to work!

coolvision commented 10 years ago

one more question. there is no indigo-devel branch for moveit_pr2 package, probably because it depends on pr2_controllers_msgs package, which is discontinued in indigo as i understand. do you think moveit_pr2 can be removed from moveit.rosinstall for indigo-devel ?

davetcoleman commented 10 years ago

no, it should not be removed. we only branch for indigo when we have to for compatibility, or if there are some really big changes that we don't want to back port to hydro.

technically, we shouldn't even have indigo branches because some of the other moveit developers wanted to keep the same exact code on both ROS releases. personally, i think its a little bit of an unattainable goal because it requires a lot more work to keep in sync, and because it could potentially cause bugs in a ROS release that should be stable by now (hydro) if we want to add new features.

130s commented 8 years ago

This seems to have been resolved back in around https://github.com/ros-planning/moveit_docs/commit/ca79518905582e7a8e16c0b575b889f69850a2d3#diff-78fe08a8f72e511b5be6ee0f66851eb1 (and today we even evolved to kinetic version).