search

moveit / moveit_docs

DEPRECATED - see https://github.com/ros-planning/moveit.ros.org
5 stars 10 forks source link

Temporarily add warehouse_ros to rosinstall #32

Closed davetcoleman closed 8 years ago

davetcoleman commented 8 years ago

Will allow moveit_ros and ros-planning/moveit_ros#699 to build until next release

130s commented 8 years ago

Just wondering; why is this temporary?

davetcoleman commented 8 years ago

1) because its not prefaced with moveit_* 2) once this package is released it won't be needed from source to build moveit 3) that's just how its always been ;-)

130s commented 8 years ago

Correct me if I'm wrong; if this file is for those (developers, CI servers etc.) who want to build MoveIt! from source, or more specifically MoveIt!-related packages from ros-planning org, then I thought it would make sense to warehouse_ros to be in this file.

(I also see it in your aggregated version but I assume that's because of the same reasoning you explained above).

davetcoleman commented 8 years ago

I agree with you, but assume others might not and its not important to me really

130s commented 8 years ago

Ok, there's advantage and disadvantage, I don't have a clear answer. Since you say not important, let's move forward.