search

moveit / moveit_ikfast

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
12 stars 20 forks source link

templates: plugin desc CMake install target missing 'planning group name' #28

Closed gavanderhoorn closed 10 years ago

gavanderhoorn commented 10 years ago

As per subject.

The generated CMakeLists.txt does not take the planning group name into account when setting up the install rule for the *_plugin_description.xml file. The group name is used when creating the plugin description file itself in create_ikfast_moveit_plugin.py, causing errors upon trying to install the package.

davetcoleman commented 10 years ago

+1 great point. I probably introduced this discrepancy when making these plugins compatible with multiple planning groups. The format as you said should be:

robot_name + "_" + planning_group_name + "_moveit_ikfast_plugin" + "_description.xml"

Can you change this commit to a PR?

gavanderhoorn commented 10 years ago

You want edf37dc in a separate PR?

davetcoleman commented 10 years ago

No, its fine, I just hadn't seen that PR / email yet.