search

moveit / moveit_ikfast

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
12 stars 20 forks source link

Fixes for 23, 27 and 28 #29

Closed gavanderhoorn closed 10 years ago

gavanderhoorn commented 10 years ago

These commits contain proposed fixes for the referenced issues.

I've had to update the way create_ikfast_moveit_plugin.py works with package dependencies, as cmake_modules is only a build_depend.

gavanderhoorn commented 10 years ago

Ping?

davetcoleman commented 10 years ago

Thanks for all these fixes!

I made some comments on the individual commits, I probably should have done them here instead, oops

gavanderhoorn commented 10 years ago

I've removed find_package(Eigen ..) from the CMakeLists.txt template, as it does indeed seem to be not used (anymore). This also removes the need for the dependency on cmake_modules, and consequently doesn't require separate handling of the run and build dependencies, but I've left the extended checking / injection in create_ikfast_moveit_plugin.py. Might be of some use in the future (but feel free to remove it).

davetcoleman commented 10 years ago

Great work, thanks!

gavanderhoorn commented 10 years ago

Thanks for merging. Makes my life a bit easier when releasing IKFast plugin packages.