search

moveit / moveit_ikfast

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
12 stars 20 forks source link

remove obsolete IKTYPE_TRANSFORM_6D defines #32

Closed cheffe112 closed 9 years ago

cheffe112 commented 10 years ago

IKFastKinematicsPlugin::getPositionFK(...) still relies on the IKTYPE_TRANSFORM_6D define which was otherwise eliminated by @mintar in pull request #13. Probably, GetIkType() would work here as well similar to #13. I'd have removed it myself, but don't know what the implications are, so I'd rather let it to someone who is sure of what they are doing.

pirobot commented 10 years ago

This fix works for me when using a 6-DOF arm.

davetcoleman commented 10 years ago

+1 to removing it

mintar commented 9 years ago

This was fixed in b8922af5 (see #33), so we can close this issue.

This shouldn't have caused any bugs anyway, since there is currently no way to enable calls to getPositionFK() (see #38).