search

moveit / moveit_ikfast

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
12 stars 20 forks source link

Delete master branch. #39

Closed davetcoleman closed 9 years ago

davetcoleman commented 9 years ago

I just made indigo-devel the default branch on Github. @gavanderhoorn is master ready to be deleted?

gavanderhoorn commented 9 years ago

I wanted to wait changing the default branch until after we'd updated rosdistro, wiki and releases.

37 has been merged, so I guess we can remove master.

davetcoleman commented 9 years ago

I've just:

gavanderhoorn commented 9 years ago

Great. Thanks for taking care of that.

PS: I seem to remember tfoote and / or dirk-thomas saying that version numbers of releases in different distributions should never be the same. Something like 1.2.x in hydro, then 1.3.x in indigo was recommended. Should we do that here as well?

davetcoleman commented 9 years ago

I haven't heard that - I could use a little more motivation for why that is. Notably - the two branches are actually exactly the same right now so having them the same version number makes sense.

I would like to get the cost feature set to on by default in indigo, however. Then we should diverge the versions.

gavanderhoorn commented 9 years ago

@davetcoleman: took some time, but I found it again, see Dirk Thomas in [ros-release] Ease comparing versions of packages between ROS distros, last bullet.

It's not so much a requirement, more a recommendation I guess.

davetcoleman commented 9 years ago

it is likely that there could be or will be two packages with the same version but different code

But for now there is not a difference in code. Next release we can diverge the version numbers.

gavanderhoorn commented 9 years ago

True. I just wanted to draw your attention to it.

davetcoleman commented 9 years ago

no problem, thanks!