search

moveit / moveit_planners

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
15 stars 34 forks source link

OMPL's getDefaultPlanner changed location breaks moveit planners #54

Closed davetcoleman closed 9 years ago

davetcoleman commented 10 years ago

This commit from the latest OMPL will potentially break MoveIt! https://github.com/ompl/ompl/commit/78f5b686b2433069b32bb50e60985e7dad8cf9be#commitcomment-7855991

IMHO we should leave getDefaultPlanners in OMPL's SimpleSetup in the short run, marked as Deprecated, and have it call the new location one. Otherwise its going to be tricky with using the latest OMPL with MoveIt!. Proper tick-tocking would be nice.

@mamoll

davetcoleman commented 10 years ago

@mamoll said: Restored deprecated functions in https://github.com/ompl/ompl/commit/0ce70f9331dda65741c5598c2c22ae5eec907188

So this is the fix for MoveIt! so that the deprecated warning won't happen: https://github.com/davetcoleman/moveit_planners/commit/57d68a7bac43de5d0dfeadd76c04b05e88946db9

I'm not sure where to merge it. Will the latest of OMPL be release for Indigo? Should I put it in a ROS-J branch? @isucan

isucan commented 10 years ago

I think we should update this for MoveIt indigo. We won't upgrade OMPL for hydro any more, but we might for indigo.

davetcoleman commented 10 years ago

+1 for updating Indigo - otherwise all of my research / dev this summer won't work for the next 4 years LTS

davetcoleman commented 9 years ago

This was fixed long ago