install plugin xml even if it's no functional controller

moveit / moveit_plugins

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit

12 stars 15 forks source link

install plugin xml even if it's no functional controller #19

Closed v4hn closed 8 years ago

v4hn commented 8 years ago

If an xml-file is referenced in the package.xml, it has to exist. Otherwise each invocation of the plugin-module will produce errors such as this one:

[ERROR] [1466021391.880651302]: Skipping XML Document "~/ros/indigo/moveit/install/share/moveit_controller_manager_example/moveit_controller_manager_example_plugin_description.xml" which had no Root Element. This likely means the XML is malformed or missing.

davetcoleman commented 8 years ago

The only downside to this PR is that it will "clutter" any generated list of available controllers, right? Seems like not a very big deal if that is all..

v4hn commented 8 years ago

Yes, it will. I don't see a problem with that either. Also this module is not released into ROS officially, so it will not be around until a user pulls this repository explicitly.