set of fake controllers

moveit / moveit_plugins

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit

12 stars 15 forks source link

set of fake controllers #21

Closed rhaschke closed 8 years ago

rhaschke commented 8 years ago

This reopens #20 against jade-devel.

Implement as set of fake controllers traversing

smoothly interpolated path
via points only
last point only

rhaschke commented 8 years ago

Revived initialization of robot state to named posture. Removed hard-coded parameters from @davetcoleman's version.

rhaschke commented 8 years ago

@davetcoleman Do you have any idea, why warehouse_ros fails in Jade's Travis?

davetcoleman commented 8 years ago

This repo is still using the old .travis.yml file, which has some sort of problem with using rosinstall files... I don't care to support it since I spent a ton of time making moveit_ci. Would you like me to add it to this repo? It would be no prob

rhaschke commented 8 years ago

Good point. I will add moveit_ci to this PR. This way it's automatically checked.

rhaschke commented 8 years ago

@davetcoleman Cool! Checks passed with new moveit_ci.

rhaschke commented 8 years ago

From my point of view, this PR could be reviewed and merged.

davetcoleman commented 8 years ago

Looks good after addressing my comments

rhaschke commented 8 years ago

I addressed most of your comments in code. See my answers to the others ;-)

rhaschke commented 8 years ago

I addressed the remaining issues. Don't mind to squash on merging ;-)

added rosdoc.yaml
call cancelTrajectory() in destructor.
moved header include to the top

davetcoleman commented 8 years ago

+1 thanks!

v4hn commented 8 years ago

So much for having different commits for different things... I doubt the .travis.yml is part of "set of fake controllers". Now it's one commit in jade-devel.

v4hn commented 8 years ago

cherry-picked to kinetic-devel, as we just discussed we don't want to have things merged in older branches if they are not also merged in the most current one...

Who do I blame... I could have already written a proposed policy for pull-requests/merging...

v4hn commented 8 years ago

@rhaschke could you backport this to indigo? It would be awsome to have continuous fake controllers ready to use in indigo. I would like to point some of my students (total MoveIt! newbies) to them for testing their projects.

rhaschke commented 8 years ago

@rhaschke could you backport this to indigo? It would be awsome to have continuous fake controllers ready to use in indigo.

Done (#23). @v4hn: Porting this to kinetic, you copied .travis.yml as is, without switching to kinetic distro. I fixed that in kinetic branch directly.

v4hn commented 8 years ago

On Wed, Jul 27, 2016 at 03:03:03PM -0700, Robert Haschke wrote:

@v4hn: Porting this to kinetic, you copied .travis.yml as is, without switching to kinetic distro. I fixed that in kinetic branch directly.

Oh crap, thanks!

That's why I would have preferred it in a separate request :)

davetcoleman commented 8 years ago

I fixed that in kinetic branch directly.

that's a bending of our protocol! :worried:

davetcoleman commented 8 years ago

Could you announce this great new feature on the mailing list?

v4hn commented 8 years ago

On Thu, Jul 28, 2016 at 05:31:25PM -0700, Dave Coleman wrote:

Could you announce this great new feature on the mailing list?

Do that on the next release. The release includes other notable features too (e.g. the "cancel" button")