Allow simple controller manager to ignore virtual joints without failing

moveit / moveit_plugins

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit

12 stars 15 forks source link

Allow simple controller manager to ignore virtual joints without failing #8

Closed davetcoleman closed 10 years ago

davetcoleman commented 10 years ago

The MoveIt Simple Controller Manager currently fails when a FollowJointJointTrajectoryController receives a request that includes a virtual joint. However, there are cases such as a biped robot where a virtual joint is included in a planning group that sends requests to the controller. While it is ok for the trajectory controller to ignore the virtual joint, it should not fail. This PR instead makes it just issue a warning.

@mmurooka

isucan commented 10 years ago

mikeferguson commented 10 years ago

LGTM

mikeferguson commented 10 years ago

I was going to merge this, given that I am still listed as the maintainer of this package. However, I see that not only have I lost commit rights, I have been removed entirely from the project, again, without any notice or explanation.

@isucan Please find a new maintainer and update the package.xml, as I will no longer be contributing to MoveIt, or any software in the ros-planning group.

isucan commented 10 years ago

I will defer to @sachinchitta

sachinchitta commented 10 years ago

@mikeferguson - your push access to MoveIt! plugins has been restored. Your contributions are appreciated - this was a mistake on my part while cleaning up the teams. Let me know if your push access is not working.