moveit / moveit_resources

URDFs, meshes, and config packages for MoveIt testing
61 stars 115 forks source link

Proper scoping for controllers in Panda Config #132

Closed DLu closed 2 years ago

DLu commented 2 years ago

moveit_controllers.yaml is inconsistent with gripper_moveit_controllers.yaml, which ihas the controller_names and declarations within the moveit_simple_controller_manager namespace.

AndyZe commented 2 years ago

I'm just curious how it even worked before this change. For example, ros2 launch moveit_resources_panda_moveit_config demo.launch.py works fine without this.

DLu commented 2 years ago

Looking back at this, demo.launch.py does not load moveit_controllers.yaml, it only loads gripper_moveit_controllers.yaml.

As far as I can see, moveit2_tutorials only uses gripper_moveit_controllers.yaml as well.

DLu commented 2 years ago

Thanks Andy!